Parse task queue stats from /proc/schedstat#186
Merged
pgier merged 1 commit intoprometheus:masterfrom Jul 2, 2019
Merged
Conversation
bitglue
force-pushed
the
schedstat
branch
3 times, most recently
from
3bd711a to
6a02a68
Compare
Contributor
Author
|
@discordianfish @pgier ready for review. I'll update prometheus/node_exporter#1389 to use this after review. |
pgier
reviewed
Jun 26, 2019
Collaborator
pgier
left a comment
pgier
left a comment
There was a problem hiding this comment.
Thanks for the contribution! I added a few comments in-line. It would be nice to also include a Proc method for getting the per-process schedstat data.
bitglue
force-pushed
the
schedstat
branch
2 times, most recently
from
67f2a4b to
c5f75d1
Compare
Contributor
Author
|
@pgier Everything addressed I think, please re-review |
bitglue
force-pushed
the
schedstat
branch
2 times, most recently
from
207a50a to
8f8adde
Compare
Contributor
Author
|
@discordianfish @pgier bump, review please |
pgier
reviewed
Jul 2, 2019
These are useful as an indication of CPU contention and scheduler latency. Signed-off-by: Phil Frost <phil@postmates.com>
Contributor
Author
|
@pgier ok, sorry to change things just after asking for review. It occured to me reading the diff with fresh eyes and a cup of coffee that there were untested corner cases. I've added some more tests and rearranged some things. Should be good now, for reals. |
Collaborator
|
Merged, thanks! |
Contributor
Author
|
What's the process for getting a released tagged so I can complete prometheus/node_exporter#1389 ? |
Contributor
Author
|
Actually now that I've learned a bit more about go modules I've figured out how to update it without a release. Seems I'm not the first one to pin node_exporter to a non-released version of procfs. |
bitglue
pushed a commit
to postmates/node_exporter
that referenced
this pull request
Jul 5, 2019
These are useful as a direct indication of CPU contention and task scheduler latency. Handy references: - https://github.com/torvalds/linux/blob/master/Documentation/scheduler/sched-stats.txt - https://doc.opensuse.org/documentation/leap/tuning/html/book.sle.tuning/cha.tuning.taskscheduler.html procfs is updated to pull in the enabling change: prometheus/procfs#186 Signed-off-by: Phil Frost <phil@postmates.com>
SuperQ
pushed a commit
to prometheus/node_exporter
that referenced
this pull request
Jul 10, 2019
These are useful as a direct indication of CPU contention and task scheduler latency. Handy references: - https://github.com/torvalds/linux/blob/master/Documentation/scheduler/sched-stats.txt - https://doc.opensuse.org/documentation/leap/tuning/html/book.sle.tuning/cha.tuning.taskscheduler.html procfs is updated to pull in the enabling change: prometheus/procfs#186 Signed-off-by: Phil Frost <phil@postmates.com>
remijouannet
pushed a commit
to remijouannet/procfs
that referenced
this pull request
Oct 20, 2022
Parse task queue stats from /proc/schedstat
bobrik
pushed a commit
to bobrik/procfs
that referenced
this pull request
Jan 14, 2023
oblitorum
pushed a commit
to shatteredsilicon/node_exporter
that referenced
this pull request
Apr 9, 2024
These are useful as a direct indication of CPU contention and task scheduler latency. Handy references: - https://github.com/torvalds/linux/blob/master/Documentation/scheduler/sched-stats.txt - https://doc.opensuse.org/documentation/leap/tuning/html/book.sle.tuning/cha.tuning.taskscheduler.html procfs is updated to pull in the enabling change: prometheus/procfs#186 Signed-off-by: Phil Frost <phil@postmates.com>
oblitorum
pushed a commit
to shatteredsilicon/node_exporter
that referenced
this pull request
Apr 9, 2024
These are useful as a direct indication of CPU contention and task scheduler latency. Handy references: - https://github.com/torvalds/linux/blob/master/Documentation/scheduler/sched-stats.txt - https://doc.opensuse.org/documentation/leap/tuning/html/book.sle.tuning/cha.tuning.taskscheduler.html procfs is updated to pull in the enabling change: prometheus/procfs#186 Signed-off-by: Phil Frost <phil@postmates.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are useful as an indication of CPU contention and scheduler
latency.