Bcache: add bdev/writeback_rate_debug stats#277
Merged
pgier merged 8 commits intoprometheus:masterfrom Apr 30, 2020
Merged
Conversation
Signed-off-by: Aleksei Zakharov <zaharov@selectel.ru>
Signed-off-by: Aleksei Zakharov <zaharov@selectel.ru>
Signed-off-by: Aleksei Zakharov <zaharov@selectel.ru>
Signed-off-by: Aleksei Zakharov <zaharov@selectel.ru>
Signed-off-by: Aleksei Zakharov <zaharov@selectel.ru>
Signed-off-by: Aleksei Zakharov <zaharov@selectel.ru>
Signed-off-by: Aleksei Zakharov <zaharov@selectel.ru>
AlexZzz
force-pushed
the
bcache_writeback_debug
branch
from
cbf920d to
68ac0f3
Compare
Signed-off-by: Aleksei Zakharov <zaharov@selectel.ru>
discordianfish
approved these changes
Apr 16, 2020
Member
remijouannet
pushed a commit
to remijouannet/procfs
that referenced
this pull request
Oct 20, 2022
Bcache: add bdev/writeback_rate_debug stats
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! This PR adds support for bache writeback_rate_debug stats.
It's called debug, but it has useful information. It shows current writeback rate, target size of dirty data and PI-controller values. It is very usefull for debugging and helps to make decision to tweak bcache's PI-controller.
@pgier @discordianfish , could you approve this?