Skip to content

Comments

Add CPUInfo parser for mipsle#307

Merged
SuperQ merged 1 commit intomasterfrom
superq/mipsle
Jun 14, 2020
Merged

Add CPUInfo parser for mipsle#307
SuperQ merged 1 commit intomasterfrom
superq/mipsle

Conversation

@SuperQ
Copy link
Member

@SuperQ SuperQ commented Jun 10, 2020

Use mips CPUInfo parser for mipsle. They appear to have identical
cpuinfo output.

prometheus/node_exporter#1735

Signed-off-by: Ben Kochie superq@gmail.com

Use mips CPUInfo parser for mipsle. They appear to have identical
cpuinfo output.

prometheus/node_exporter#1735

Signed-off-by: Ben Kochie <superq@gmail.com>
@SuperQ SuperQ requested review from discordianfish and pgier June 10, 2020 11:51
@SuperQ
Copy link
Member Author

SuperQ commented Jun 12, 2020

Ping, this is blocking the release of some node_exporter bug fixes.

Copy link
Member

@roidelapluie roidelapluie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmhh see comment

@roidelapluie
Copy link
Member

Or you miss the mipsle tag instead

Copy link
Member

@roidelapluie roidelapluie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting that correct build tag is added

Copy link
Member

@roidelapluie roidelapluie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL; thanks.

@SuperQ SuperQ merged commit b23b502 into master Jun 14, 2020
@SuperQ SuperQ deleted the superq/mipsle branch June 14, 2020 06:40
remijouannet pushed a commit to remijouannet/procfs that referenced this pull request Oct 20, 2022
Use mips CPUInfo parser for mipsle. They appear to have identical
cpuinfo output.

prometheus/node_exporter#1735

Signed-off-by: Ben Kochie <superq@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants