Skip to content

Comments

Handle multi-digit powercap indexes#320

Merged
SuperQ merged 1 commit intomasterfrom
superq/rapl_split
Aug 24, 2020
Merged

Handle multi-digit powercap indexes#320
SuperQ merged 1 commit intomasterfrom
superq/rapl_split

Conversation

@SuperQ
Copy link
Member

@SuperQ SuperQ commented Aug 6, 2020

Correctly handle powercap name strings by splitting on "-" rather than
assuming the index is a single digit number.

prometheus/node_exporter#1808

Signed-off-by: Ben Kochie superq@gmail.com

@SuperQ
Copy link
Member Author

SuperQ commented Aug 6, 2020

I need to get some sample fixtures to test this out.

Copy link
Contributor

@uniemimu uniemimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Correctly handle powercap name strings by splitting on "-" rather than
assuming the index is a single digit number.

prometheus/node_exporter#1808

Signed-off-by: Ben Kochie <superq@gmail.com>
@SuperQ SuperQ merged commit 840ab91 into master Aug 24, 2020
@SuperQ SuperQ deleted the superq/rapl_split branch August 24, 2020 15:32
remijouannet pushed a commit to remijouannet/procfs that referenced this pull request Oct 20, 2022
Correctly handle powercap name strings by splitting on "-" rather than
assuming the index is a single digit number.

prometheus/node_exporter#1808

Signed-off-by: Ben Kochie <superq@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants