Added parsing of "checking" state to mdstat#321
Merged
discordianfish merged 1 commit intoprometheus:masterfrom Aug 24, 2020
Merged
Added parsing of "checking" state to mdstat#321discordianfish merged 1 commit intoprometheus:masterfrom
discordianfish merged 1 commit intoprometheus:masterfrom
Conversation
Signed-off-by: Christian Rohmann <github@frittentheke.de>
paulfantom
approved these changes
Aug 18, 2020
Contributor
There was a problem hiding this comment.
Tested with prometheus/node_exporter#1810 on my personal RAID. Seems to be working as expected.
/lgtm
/cc @SuperQ
discordianfish
approved these changes
Aug 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the checking state caused by i.e. checkarray (see https://www.thomas-krenn.com/en/wiki/Mdadm_checkarray_function#Perform_Automatic_Check) is not parsed as state an array can be in.
This is unfortunate as this condition certainly makes sense to monitor and take into considerations when writing alerts on i.e. disk read rates or total blocks vs. in sync blocks.
Signed-off-by: Christian Rohmann github@frittentheke.de
@discordianfish @pgier PTAL