sysfs/net_class: filter devices by name#378
Closed
jan--f wants to merge 1 commit intoprometheus:masterfrom
Closed
Conversation
This adds regexp-based device filtering to the NetClass function in order to avoid parsing devices files that are uninteresting. Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
Merged
Author
|
@discordianfish the accompanying node_exporter patch looks something like this: https://github.com/prometheus/node_exporter/compare/master...jan--f:pass-netclass-filter-to-procfs?expand=1 |
Author
|
Keeping the filtering in the consumer is preferred, see #376. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds regexp-based device filtering to the NetClass function in order to avoid
parsing devices files that are uninteresting.
Signed-off-by: Jan Fajerski jfajersk@redhat.com
Fixes: prometheus/node_exporter#1915
This will have an accompanying PR in the node_exporter, but I wanted to check first if the API change should be made more backwards compatible by introducing a new function that takes the regex as an argument, instead of changing the signature of
NetClassDevices().