Merged
Conversation
SuperQ
reviewed
May 22, 2021
SuperQ
reviewed
May 22, 2021
SuperQ
reviewed
May 22, 2021
luizluca
force-pushed
the
scsitape
branch
2 times, most recently
from
c389393 to
aa33d7b
Compare
Contributor
Author
|
Is there anything else pending? |
Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
Contributor
Author
|
I just forced-push the review suggestions. I'll do the same for node_exporter collector. |
discordianfish
approved these changes
Jul 1, 2021
Member
|
Awesome, thanks @luizluca! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For prometheus/node_exporter#2044
Signed-off-by: Luiz Angelo Daros de Luca luizluca@gmail.com