Skip to content

Comments

Add support for DMI information#409

Merged
discordianfish merged 1 commit intoprometheus:masterfrom
bdrung:dmi
Oct 11, 2021
Merged

Add support for DMI information#409
discordianfish merged 1 commit intoprometheus:masterfrom
bdrung:dmi

Conversation

@bdrung
Copy link
Contributor

@bdrung bdrung commented Aug 26, 2021

The sysfs contains some useful information about the BIOS, board, chassis, product, and system from the Desktop Management Interface (DMI). The BIOS version should be exported by the Prometheus node exporter to support alerting about outdated BIOS versions. Add a DMIClass function to collect the information for the node exporter.

@bdrung bdrung force-pushed the dmi branch 2 times, most recently from c61d653 to 5114b0c Compare August 27, 2021 07:46
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperQ SuperQ requested a review from discordianfish August 27, 2021 08:17
The sysfs contains some useful information about the BIOS, board,
chassis, product, and system from the Desktop Management Interface
(DMI). The BIOS version should be exported by the Prometheus node
exporter to support alerting about outdated BIOS versions. Add a
`DMIClass` function to collect the information for the node exporter.

Signed-off-by: Benjamin Drung <benjamin.drung@ionos.com>
@bdrung
Copy link
Contributor Author

bdrung commented Aug 27, 2021

I needed to change the f.IsDir() to !f.Mode().IsRegular() since this directory can also contain symlinks to directories.

Copy link
Member

@discordianfish discordianfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

@bdrung
Copy link
Contributor Author

bdrung commented Oct 11, 2021

Any updates on this merge request?

@discordianfish
Copy link
Member

Oh sorry, I didn't realize SuperQ already approved.

@discordianfish discordianfish merged commit 1a7a2bd into prometheus:master Oct 11, 2021
@bdrung bdrung deleted the dmi branch October 12, 2021 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants