Add isolated cpu parsing#427
Merged
discordianfish merged 6 commits intoprometheus:masterfrom Dec 20, 2021
Merged
Conversation
Signed-off-by: david <davidventura27@gmail.com>
DavidVentura
force-pushed
the
add-isolated-cpu-parsing
branch
from
1c26c97 to
4dd3d46
Compare
Member
|
Beside that, looks good - especially for a first time go contribution 🥳 |
Signed-off-by: david <davidventura27@gmail.com>
Signed-off-by: david <davidventura27@gmail.com>
discordianfish
approved these changes
Dec 17, 2021
Member
discordianfish
left a comment
discordianfish
left a comment
There was a problem hiding this comment.
Beside that last nit, LGTM. Thanks!
Signed-off-by: david <davidventura27@gmail.com>
Signed-off-by: david <davidventura27@gmail.com>
SuperQ
approved these changes
Dec 18, 2021
Signed-off-by: david <davidventura27@gmail.com>
remijouannet
pushed a commit
to remijouannet/procfs
that referenced
this pull request
Oct 20, 2022
* Add isolated cpu parsing Signed-off-by: david <davidventura27@gmail.com> * Address PR comments Signed-off-by: david <davidventura27@gmail.com> * Fix start/end range message Signed-off-by: david <davidventura27@gmail.com> * rename to parseIsolatedCPUs Signed-off-by: david <davidventura27@gmail.com> * Do not wrap error Signed-off-by: david <davidventura27@gmail.com> * also check error is nil Signed-off-by: david <davidventura27@gmail.com>
jritter
pushed a commit
to jritter/procfs
that referenced
this pull request
Jul 15, 2024
* Add isolated cpu parsing Signed-off-by: david <davidventura27@gmail.com> * Address PR comments Signed-off-by: david <davidventura27@gmail.com> * Fix start/end range message Signed-off-by: david <davidventura27@gmail.com> * rename to parseIsolatedCPUs Signed-off-by: david <davidventura27@gmail.com> * Do not wrap error Signed-off-by: david <davidventura27@gmail.com> * also check error is nil Signed-off-by: david <davidventura27@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi
This PR adds support for parsing
/sys/devices/system/cpu/isolatedPrompted by this PR for node_exporter
I am not sure if this should be a
uint16or not.