parsing /proc/stat by CPU ID#438
Merged
discordianfish merged 1 commit intoprometheus:masterfrom Sep 29, 2022
Merged
Conversation
3f28287 to
18ac0a2
Compare
Member
|
Just the newStat() thing, generally this seems reasonable, thanks! |
pgier
approved these changes
Mar 23, 2022
Collaborator
pgier
left a comment
There was a problem hiding this comment.
Thanks for the contribution, just had a couple in-line suggestions.
18ac0a2 to
754b774
Compare
Signed-off-by: Jia Xin <alexjx@gmail.com>
754b774 to
5864e10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a case that some of the cpu (threads) are offline intentionally (see lscpu below), procfs will "interpolate" those offline values. This patch made the /proc/stat parsing with the real cpu ID.