fs: Statfs_t{} doesn't have a Type field on NetBSD, OpenBSD, or Solaris#523
Merged
SuperQ merged 1 commit intoprometheus:masterfrom May 20, 2023
Merged
fs: Statfs_t{} doesn't have a Type field on NetBSD, OpenBSD, or Solaris#523SuperQ merged 1 commit intoprometheus:masterfrom
SuperQ merged 1 commit intoprometheus:masterfrom
Conversation
Other projects that import procfs, like node_exporter, apparently build for OSs that don't have Statfs_t.Type. Signed-off-by: Dan Williams <dcbw@redhat.com>
Contributor
Author
|
See https://app.circleci.com/pipelines/github/prometheus/node_exporter/3445/workflows/1ca8faff-eabc-45fd-a7f1-0b07dffd6569/jobs/18019 for the full node_exporter CI failure |
SuperQ
requested changes
May 20, 2023
Member
SuperQ
left a comment
There was a problem hiding this comment.
The convention for naming these files would be fs_linux.go and fs_others.go, see how the naming and tags are done for cpuinfo*.go.
SuperQ
approved these changes
May 20, 2023
Member
SuperQ
left a comment
There was a problem hiding this comment.
On second thought, this is fine.
Contributor
Author
|
@SuperQ I thought about that, but given that FreeBSD/Darwin also have Type, and at least FreeBSD can emulate Linux procfs with the same magic as Linux, didn't seem quite right to make it _linux.go. |
This was referenced May 28, 2023
jritter
pushed a commit
to jritter/procfs
that referenced
this pull request
Jul 15, 2024
…is (prometheus#523) Other projects that import procfs, like node_exporter, apparently build for OSs that don't have Statfs_t.Type. Signed-off-by: Dan Williams <dcbw@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Other projects that import procfs, like node_exporter, apparently build for OSs that don't have Statfs_t.Type.
Leads to errors like (for node_exporter):