Merged
Conversation
Member
Author
|
Note, the UI tests use golang-builder's Nodejs version, which doesn't use the node version config file. |
bboreham
approved these changes
Aug 26, 2023
Member
bboreham
left a comment
bboreham
left a comment
There was a problem hiding this comment.
Within the bounds of my JS knowledge, this seems fine.
Note the Windows tests flaked first time around.
SuperQ
force-pushed
the
superq/bump_node
branch
from
a6412f8 to
b134d76
Compare
Member
Author
|
Related golang-builder PR: prometheus/golang-builder#222 I tested a local build with NodeJS 20, everything looks OK. |
Update to the latest nodejs LTS release. The old v16 ends security support 2023.09.11. * https://nodejs.org/en/blog/announcements/v20-release-announce * https://nodejs.org/en/blog/announcements/nodejs16-eol Signed-off-by: SuperQ <superq@gmail.com>
SuperQ
force-pushed
the
superq/bump_node
branch
from
b134d76 to
23988a9
Compare
Member
Author
|
Rebuilding, golang-builder images now have nodejs 20. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to the latest nodejs LTS release. The old v16 ends security support 2023.09.11.