Skip to content

Comments

update vendor'd github.com/prometheus/common/config#4174

Merged
fabxc merged 1 commit intoprometheus:masterfrom
adamdecaf:upate-common-2018-05-18
May 28, 2018
Merged

update vendor'd github.com/prometheus/common/config#4174
fabxc merged 1 commit intoprometheus:masterfrom
adamdecaf:upate-common-2018-05-18

Conversation

@adamdecaf
Copy link
Contributor

@adamdecaf adamdecaf commented May 18, 2018

Updating from prometheus/common#135

Via:

$ govendor update github.com/prometheus/common/config

Fixes: #4173

@krasi-georgiev
Copy link
Contributor

shouldn't this be done using fetch instead of update to get the latest from the repo rather than the local copy?
or maybe even include all subpackages

govendor fetch github.com/prometheus/common/...

@krasi-georgiev
Copy link
Contributor

I always forget the correct commands so I added a simple wiki page with the examples. Feel free to update if you see anything wrong.
https://github.com/prometheus/prometheus/wiki/Updating-a-vendored-package

Signed-off-by: Adam Shannon <adamkshannon@gmail.com>
@adamdecaf adamdecaf force-pushed the upate-common-2018-05-18 branch from bf5f86a to ea761c5 Compare May 22, 2018 14:19
@adamdecaf
Copy link
Contributor Author

adamdecaf commented May 22, 2018

@krasi-georgiev Thanks. I get the various tool commands confused. I ran your fetch command and pushed.

@krasi-georgiev
Copy link
Contributor

yep I am the same that is why I did the wiki page.
vgo should change that soon :)

@krasi-georgiev
Copy link
Contributor

Thanks LGTM 👍

@fabxc fabxc merged commit 56e6679 into prometheus:master May 28, 2018
@adamdecaf adamdecaf deleted the upate-common-2018-05-18 branch May 28, 2018 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants