Cleanup bstream based on post-merge feedback received on 7390

[pracucci]

@codesome left some valuable feedback to #7390 after getting it merged. In this PR I'm addressing the feedback.

We also agreed offline to not address this comment because it's hard to know whether the Fast() version of a function is expected to return an error or not for every single call.

[codesome]

Thanks! Will merge on green

[roidelapluie]

Where is the copyright going then?

[roidelapluie]

"Redistributions of source code must retain the above copyright notice"

[pracucci]

Where is the copyright going then?

It was erroneously copied from bstream.go but it doesn't apply to the test file. The test file should just have the standard Prometheus license.

[roidelapluie]

For bstream.go, to respect Redistributions in binary form must reproduce the above copyright notice, it should be added in the NOTICE file.

[codesome]

The code in bstream_test.go does not copy any code from there, so I don't think it's necessary

[roidelapluie]

for _test, ok but bstream.go sounds like something that should be added to NOTICE for the binary redistribution

[codesome]

Let's fix that in another PR

[bwplotka]

Nice 👍