Add codesign utility function#284
Merged
SuperQ merged 1 commit intoprometheus:masterfrom Apr 14, 2024
Merged
Conversation
gitperr
changed the title
Contributor
Author
|
@SuperQ wanna take a look? |
SuperQ
requested changes
Feb 18, 2024
Member
SuperQ
left a comment
SuperQ
left a comment
There was a problem hiding this comment.
Minor nit, otherwise LGTM.
We're also going to need to plumb this into our CI templates so that it's done automatically.
Contributor
Author
|
Squashed, will make changes to prometheus/node_exporter#2916 as well to accompany this. |
gitperr
added a commit
to gitperr/node_exporter
that referenced
this pull request
Feb 18, 2024
The functionality being replaced here is going to be built into `promu` with prometheus/promu#284 So pipelines should use it instead. Signed-off-by: Alper Polat <gitperr@gmail.com>
gitperr
force-pushed
the
master
branch
2 times, most recently
from
662a10b to
4fb85da
Compare
Contributor
Author
|
Updated README as well now. And squashed again. Should be good to go, please take another look. This should be merged before prometheus/node_exporter#2916 to make pipelines start working properly with |
Signed-off-by: Alper Polat <gitperr@gmail.com> Add rcodesign as a new utility function Signed-off-by: Alper Polat <gitperr@gmail.com> Update year to 2024 Signed-off-by: Alper Polat <gitperr@gmail.com> Update README Signed-off-by: Alper Polat <gitperr@gmail.com> Indicate that the binary to be signed is darwin binary Signed-off-by: Alper Polat <gitperr@gmail.com> Gofumpt to get rid of linter warnings Signed-off-by: Alper Polat <gitperr@gmail.com>
Contributor
Author
|
@roidelapluie does this PR look good? |
Contributor
Author
|
Is there anyone else we can ask review from? If roidelapluie is busy, maybe someone else could take a look? |
SuperQ
added a commit
that referenced
this pull request
Apr 14, 2024
* [FEATURE] Add codesign utility function #284 Signed-off-by: SuperQ <superq@gmail.com>
Merged
SuperQ
added a commit
that referenced
this pull request
Apr 14, 2024
* [FEATURE] Add codesign utility function #284 Signed-off-by: SuperQ <superq@gmail.com>
SuperQ
added a commit
that referenced
this pull request
Apr 19, 2024
* [FEATURE] Add codesign utility function #284 Signed-off-by: SuperQ <superq@gmail.com>
gitperr
added a commit
to gitperr/node_exporter
that referenced
this pull request
Apr 30, 2024
Signed-off-by: Alper Polat <gitperr@gmail.com> Bump golang-builder version (prometheus#2908) Signed-off-by: Alper Polat <gitperr@gmail.com> exec_bsd: Fix labels for vm.stats.sys.v_syscall sysctl (prometheus#2895) Signed-off-by: David O'Rourke <david.orourke@gmail.com> chore:remove constant from function (prometheus#2884) Signed-off-by: tyltr <tylitianrui@126.com> build(deps): bump github.com/prometheus/common from 0.45.0 to 0.46.0 (prometheus#2910) Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.45.0 to 0.46.0. - [Release notes](https://github.com/prometheus/common/releases) - [Commits](prometheus/common@v0.45.0...v0.46.0) --- updated-dependencies: - dependency-name: github.com/prometheus/common dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> build(deps): bump github.com/jsimonetti/rtnetlink from 1.4.0 to 1.4.1 (prometheus#2909) Bumps [github.com/jsimonetti/rtnetlink](https://github.com/jsimonetti/rtnetlink) from 1.4.0 to 1.4.1. - [Release notes](https://github.com/jsimonetti/rtnetlink/releases) - [Commits](jsimonetti/rtnetlink@v1.4.0...v1.4.1) --- updated-dependencies: - dependency-name: github.com/jsimonetti/rtnetlink dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> fix hwmon nil ptr (prometheus#2873) * fix hwmon nil ptr syslink maybe lost in some cases. --------- Signed-off-by: TaoGe <6657718+yowenter@users.noreply.github.com> Fix hwmon error capture (prometheus#2915) Fix golangci-lint "ineffectual assignment" by correctly capturing any errors within the hwmon gathering loop. Signed-off-by: Ben Kochie <superq@gmail.com> Attempt to sign the node exporter darwin build This should hopefully fix the SIGKILL issue on OSX machines. e.g. in: prometheus#2539 Signed-off-by: Alper Polat <gitperr@gmail.com> Change the docker flags to correct ones Signed-off-by: Alper Polat <gitperr@gmail.com> Fix errors in running the rcodesign from golang-builder Signed-off-by: Alper Polat <gitperr@gmail.com> Use pwd instead Readlink does not work to get the proper path, pwd might do it. As promu seems to be copying the binaries based on working directory. Signed-off-by: Alper Polat <gitperr@gmail.com> Try to run at the same job to see if it helps So far I am unable to find the binary's location with either pwd or readlink. I'm suspecting that the binary is not on this specific host that is running the rcodesign. Signed-off-by: Alper Polat <gitperr@gmail.com> Try to debug what files are in the current working directory Signed-off-by: Alper Polat <gitperr@gmail.com> Print working directory as well Signed-off-by: Alper Polat <gitperr@gmail.com> Add quote wrapping Signed-off-by: Alper Polat <gitperr@gmail.com> Try to debug more Signed-off-by: Alper Polat <gitperr@gmail.com> Nothing seems to be in .build directory here Signed-off-by: Alper Polat <gitperr@gmail.com> Remove some of debug commands Seems like the build does not get produced because of the CircleCI node index that gets passed into `--parallelism-thread`. Signed-off-by: Alper Polat <gitperr@gmail.com> Add a separate sign stage for code signing Separate stage might be useful so that we have all of the builds that end up in `.build` here, and sign the one(s) that we want. First one being implemented here is darwin-arm64. Signed-off-by: Alper Polat <gitperr@gmail.com> Run only if darwin-arm64 was built Earlier I tried to add a separate stage for signing, but seems like that was a bad idea because the pipeline file has to exist in `master` for that so we can run the tests properly. Checking with if might be one of the simpler and better ideas... Signed-off-by: Alper Polat <gitperr@gmail.com> Add forgotten quote Fixing basic syntax error Signed-off-by: Alper Polat <gitperr@gmail.com> Update common Prometheus files (prometheus#2917) Signed-off-by: prombot <prometheus-team@googlegroups.com> Use promu to code sign The functionality being replaced here is going to be built into `promu` with prometheus/promu#284 So pipelines should use it instead. Signed-off-by: Alper Polat <gitperr@gmail.com> Use Promu 0.17.0 Signed-off-by: Alper Polat <gitperr@gmail.com> Introduce one error first We want to re-trigger the pipeline. But, the circleCI interface does not allow re-runs. So, going to introduce a dummy error, take it back and re-trigger the pipeline like that. Signed-off-by: Alper Polat <gitperr@gmail.com> Set version to correct one Signed-off-by: Alper Polat <gitperr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calls on
rcodesignto code sign a target binary.TODO:
Add tests(no good way of doing this,rcodesign verifydoes not work very well with this warning:(the verify command is known to be buggy and gives misleading results; we highly recommend using Apple's tooling until this message is removed)