Avoid bind-mounting to allow building with a remote docker engine#95
Merged
SuperQ merged 1 commit intoprometheus:masterfrom Nov 29, 2018
Merged
Conversation
Signed-off-by: Dave Henderson <David.Henderson@qlik.com>
Contributor
|
LGTM. This also has the benefit of creating the .build output directory owned by the current user instead of root. |
Member
|
Should we make this a config option? |
SuperQ
approved these changes
Nov 28, 2018
Member
SuperQ
left a comment
SuperQ
left a comment
There was a problem hiding this comment.
LGTM, it might be interesting to make this optional, but for now I think the speed lost is worth the ability to run in remote docker.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #94
This works when running against a remote Docker engine (for example, in CircleCI), but this is slower, since it adds the step of recursively copying the current working directory into the build container, rather than being bind-mounted in.
Signed-off-by: Dave Henderson David.Henderson@qlik.com