Implemented smart hashing of batch updates for LMT#305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new batch-setLeaf algorithm that optimizes the amount of hashes we have to do.$height$ amount of hashes, but we can be smart about it and go level by level, in the process merging paths of leaves where they converge.
The tldr on this is that if we set each leaf after the other, we do
This is less useful for the previous tree implementation, where the leafs are randomly distributed and therefore very sparse. But for the LMT, where we place leafs one-by-one strictly incrementing their tree index, big parts of the paths will overlay, therefore giving us a decent speedup for batch updates.
LMT with batch update vs. vanilla LMT
100 transfers with unqiue state slots:
result generation:
5357ms vs 6987ms
therefore roughly a 30% speedup