Conversation
marten-seemann
force-pushed
the
repo-health
branch
from
70b276a to
b2ebc8d
Compare
marten-seemann
force-pushed
the
repo-health
branch
from
b2ebc8d to
17e902b
Compare
| return | ||
| fi | ||
| diff go.sum go.sum.orig > /dev/null | ||
| echo $? |
There was a problem hiding this comment.
why echo? We could just do what we do for the other commands (capture the return status)
| for repo in $(node get-repos/index.js -l Go | jq -r '.[]'); do | ||
| tmp=$(mktemp -d) | ||
| pushd $tmp > /dev/null | ||
| git clone -q https://github.com/$repo . |
There was a problem hiding this comment.
so... it would be nice if there were a way to tell this to clone from local repos... E.g., from a gopath.
Maybe just make the https://github.com part configurable?
| echo "$repo $numcommits true" | ||
| fi | ||
| fi | ||
| popd > /dev/null |
There was a problem hiding this comment.
I'd honestly just run this all in a subshell unless we need it to be in the main shell. I.e., replace the push/pop with
(
...
)
|
We haven't been using this script in a while, and we do try to cover new Go repos as soon as they're created, but it might be interesting to run it and see what's the situation with the repos that are yet not covered. I'm going to merge it as-is as it's not on a critical path. |
3 participants
Depends on #145, as it used the
get-reposscript.This is the script that was used to generate the Go Repo Health spreadsheet, now with an added column indicating if web3-bot already created a PR or not.