PHP: google/protobuf requires bcmath extension

[chingor13]

The PHP library version requires the bcmath PHP extension but there is no documentation or declared dependency in composer.json.

If bcmath is not installed, you get:

PHP Fatal error: Uncaught Error: Call to undefined function Google\Protobuf\Internal\bccomp() in /app/vendor/google/protobuf/php/src/Google/Protobuf/Internal/Message.php:882

[atrauzzi]

Just hit this today as well, should this be moved from suggest to requires?

[TeBoring]

bcmath is only required for php implementation when json encode/decode is needed.

[TeBoring]

Probably, add a warning/error to explicitly name the error?

[atrauzzi]

That sounds good. Yeah, if someone isn't using the JSON stuff, then it's not essential.

[rickslayer]

In my case I just install the module PHP bcmath

[atrauzzi]

Right, but if someone doesn't need it, then they're being forced to install an extension they don't plan on using.

[Eitol]

I am a user of the cloud vision library for PHP and this caused me a problem. They should fix it

[Eitol]

the problematic code:

annotateImage( fopen('/var/www/html/project/data/perfect.png', 'r'), [Type::IMAGE_PROPERTIES] ); // Determine if the detected faces have headwear. foreach ($annotation->getLocalizedObjectAnnotations() as $objectAnnotation) { $value = Likelihood::name($objectAnnotation->getHeadwearLikelihood()); echo "Likelihood of headwear: $value" . PHP_EOL; }

[paslandau]

FYI: If you can't install the extension for some reason (e.g. EOL legacy system and extension repository was removed), you can use https://github.com/phpseclib/bcmath_compat as a polyfill

[haberman]

Is any action required on this issue still?

[haberman]

Closing. There is another open issue for this here: #4465