CMake: use add_compile_options instead of add_definitions for compile options#10293
Merged
acozzette merged 1 commit intoprotocolbuffers:mainfrom Jul 26, 2022
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Neumann-A
force-pushed
the
use_compile_options
branch
from
625f458 to
fc6d8e9
Compare
acozzette
approved these changes
Jul 26, 2022
|
@Neumann-A Thanks! |
zwassall-gentuity
added a commit
to zwassall-gentuity/onnxruntime
that referenced
this pull request
Feb 28, 2025
This introduces some extra changes to the non-vcpkg configuration that were in cmake/vcpkg-ports/protobuf/protobuf_cmake.patch but not cmake/patches/protobuf/protobuf_cmake.patch. I believe that the changes are all welcome; in particular, the new changes to CMakeLists.txt in the patch file (from protocolbuffers/protobuf#10293) fix resource compiler invocations in some situations, as was the case for me using clang-cl on Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes:
CMAKE_RC_COMPILE_OBJECT