Skip to content

fix(cmake): abseil and protobuf msvc static runtime must have the same value#20644

Closed
carlocorradini wants to merge 1 commit intoprotocolbuffers:mainfrom
carlocorradini:abseil_msvc_static_runtime
Closed

fix(cmake): abseil and protobuf msvc static runtime must have the same value#20644
carlocorradini wants to merge 1 commit intoprotocolbuffers:mainfrom
carlocorradini:abseil_msvc_static_runtime

Conversation

@carlocorradini
Copy link
Copy Markdown
Contributor

Fix #20355

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Mar 11, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@acozzette acozzette added cmake 🅰️ safe for tests Mark a commit as safe to run presubmits over and removed 🅰️ safe for tests Mark a commit as safe to run presubmits over labels Mar 11, 2025
@github-actions github-actions Bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Mar 11, 2025
@acozzette
Copy link
Copy Markdown

@carlocorradini Thanks for fixing this!

copybara-service Bot pushed a commit that referenced this pull request Mar 12, 2025
FUTURE_COPYBARA_INTEGRATE_REVIEW=#20644 from carlocorradini:abseil_msvc_static_runtime ce2ca2f
PiperOrigin-RevId: 735444000
copybara-service Bot pushed a commit that referenced this pull request Mar 12, 2025
COPYBARA_INTEGRATE_REVIEW=#20644 from carlocorradini:abseil_msvc_static_runtime ce2ca2f
FUTURE_COPYBARA_INTEGRATE_REVIEW=#20644 from carlocorradini:abseil_msvc_static_runtime ce2ca2f
PiperOrigin-RevId: 736280716
@copybara-service copybara-service Bot mentioned this pull request Mar 12, 2025
copybara-service Bot pushed a commit that referenced this pull request Mar 12, 2025
COPYBARA_INTEGRATE_REVIEW=#20644 from carlocorradini:abseil_msvc_static_runtime ce2ca2f
FUTURE_COPYBARA_INTEGRATE_REVIEW=#20644 from carlocorradini:abseil_msvc_static_runtime ce2ca2f
PiperOrigin-RevId: 736276937
@copybara-service copybara-service Bot mentioned this pull request Mar 12, 2025
copybara-service Bot pushed a commit that referenced this pull request Mar 12, 2025
COPYBARA_INTEGRATE_REVIEW=#20644 from carlocorradini:abseil_msvc_static_runtime ce2ca2f
FUTURE_COPYBARA_INTEGRATE_REVIEW=#20644 from carlocorradini:abseil_msvc_static_runtime ce2ca2f
PiperOrigin-RevId: 736280716
copybara-service Bot pushed a commit that referenced this pull request Mar 12, 2025
COPYBARA_INTEGRATE_REVIEW=#20644 from carlocorradini:abseil_msvc_static_runtime ce2ca2f
FUTURE_COPYBARA_INTEGRATE_REVIEW=#20644 from carlocorradini:abseil_msvc_static_runtime ce2ca2f
PiperOrigin-RevId: 734295895
@copybara-service copybara-service Bot mentioned this pull request Mar 12, 2025
copybara-service Bot pushed a commit that referenced this pull request Mar 12, 2025
COPYBARA_INTEGRATE_REVIEW=#20644 from carlocorradini:abseil_msvc_static_runtime ce2ca2f
FUTURE_COPYBARA_INTEGRATE_REVIEW=#20644 from carlocorradini:abseil_msvc_static_runtime ce2ca2f
PiperOrigin-RevId: 734280372
@copybara-service copybara-service Bot mentioned this pull request Mar 12, 2025
copybara-service Bot pushed a commit that referenced this pull request Mar 12, 2025
COPYBARA_INTEGRATE_REVIEW=#20644 from carlocorradini:abseil_msvc_static_runtime ce2ca2f
FUTURE_COPYBARA_INTEGRATE_REVIEW=#20644 from carlocorradini:abseil_msvc_static_runtime ce2ca2f
PiperOrigin-RevId: 736126837
@copybara-service copybara-service Bot mentioned this pull request Mar 12, 2025
copybara-service Bot pushed a commit that referenced this pull request Mar 12, 2025
COPYBARA_INTEGRATE_REVIEW=#20644 from carlocorradini:abseil_msvc_static_runtime ce2ca2f
FUTURE_COPYBARA_INTEGRATE_REVIEW=#20644 from carlocorradini:abseil_msvc_static_runtime ce2ca2f
PiperOrigin-RevId: 735855428
@copybara-service copybara-service Bot mentioned this pull request Mar 12, 2025
copybara-service Bot pushed a commit that referenced this pull request Mar 12, 2025
COPYBARA_INTEGRATE_REVIEW=#20644 from carlocorradini:abseil_msvc_static_runtime ce2ca2f
FUTURE_COPYBARA_INTEGRATE_REVIEW=#20644 from carlocorradini:abseil_msvc_static_runtime ce2ca2f
PiperOrigin-RevId: 736126837
copybara-service Bot pushed a commit that referenced this pull request Mar 12, 2025
COPYBARA_INTEGRATE_REVIEW=#20644 from carlocorradini:abseil_msvc_static_runtime ce2ca2f
FUTURE_COPYBARA_INTEGRATE_REVIEW=#20644 from carlocorradini:abseil_msvc_static_runtime ce2ca2f
PiperOrigin-RevId: 734280372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incompatible MSVC runtime linking between Abseil dependency and Protobuf

2 participants