Add option for PHP to emit default values for JSON.#23985
Add option for PHP to emit default values for JSON.#23985SpencerMalone wants to merge 1 commit intoprotocolbuffers:mainfrom
Conversation
dcc8b6b to
7cb3b2d
Compare
|
I think you handled this right already from initial review, but just an FYI that the language in the guidance for option to emit default values has since been updated the original issue was opened to be more precise about explicit vs implicit presence, outside of proto3. https://protobuf.dev/programming-guides/json/#json-options
|
7cb3b2d to
6d8bc74
Compare
|
This roughly lgtm, but @mkruskal-google to review for PHP. |
|
Thanks y'all! |
|
What is the process for getting this cut into a release? Do I need to do anything further? |
|
Looks like this missed the branch cut for our 33.x release, but should get picked up for our v34.0 release in Q1 which we'll be starting RC's for soon. |
|
Thank you! |
This is a reopening of #6035, where it was requested that someone contribute a PR. I chose the option name
EMIT_DEFAULTSto match the ruby client and existing upd option. I tried to be relatively comprehensive with the tests, but let me know if there's anything stylistically or logically you want changed.Locally the tests run happily: