Emulated python aarch64 tests#8392
Conversation
|
CC @janaknat |
dlj-NaN
left a comment
dlj-NaN
left a comment
There was a problem hiding this comment.
(Just a question, let me know your answer...)
| # Running protoc under an emulator is fast as protoc doesn't | ||
| # really do much. | ||
|
|
||
| # create a simple shell wrapper that runs crosscompiled protoc under qemu |
There was a problem hiding this comment.
Can this just be committed, instead of generating it on the fly?
There was a problem hiding this comment.
Definitely. We could create protoc_qemu_wrapper_aarch64.sh file (or similar name) in the repo.
It would make the script simpler. I felt like committing helpers like this into the repo might be considered "dirty", but yeah, on the other hand it makes the CI scripts simpler.
Leaving up to you which version you're the most happy with.
There was a problem hiding this comment.
This way is fine with me. (This is such a weird corner case, anyhow...)
| # Running protoc under an emulator is fast as protoc doesn't | ||
| # really do much. | ||
|
|
||
| # create a simple shell wrapper that runs crosscompiled protoc under qemu |
There was a problem hiding this comment.
This way is fine with me. (This is such a weird corner case, anyhow...)
jtattermusch
force-pushed
the
protobuf_emulated_aarch64_tests
branch
from
5c977df to
25788aa
Compare
|
Rebased (now that #8280 has been merged). |
jtattermusch
force-pushed
the
protobuf_emulated_aarch64_tests
branch
from
a7cbec8 to
63c7929
Compare
|
Should be ready to merge now. |
3 participants
Similar to #8391 (which adds C++ emulated tests), but requires a bit more trickery since we need aarch64 python to run the python tests.
Based on #8280.
kokoro/linux/aarch64/test_python_aarch64.shBased on the tests in this PR, I'm pretty confident that the wheels being added in #8280 actually work fine (the crosscompiled python extension passed all the unittests, the wheel does pass auditwheel check and it's also installable and a smokecheck works).