constinit not working as expected in Visual Studio 2019 Update 16.10#8690
Merged
fowles merged 1 commit intoprotocolbuffers:masterfrom Jun 3, 2021
maxgolov:maxgolov/vs2019_16.10_constinit_broken
Merged
constinit not working as expected in Visual Studio 2019 Update 16.10#8690fowles merged 1 commit intoprotocolbuffers:masterfrom maxgolov:maxgolov/vs2019_16.10_constinit_broken
fowles merged 1 commit intoprotocolbuffers:masterfrom
maxgolov:maxgolov/vs2019_16.10_constinit_broken
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Contributor
Author
|
@googlebot I signed it! |
Contributor
Author
|
I don't have permission to add label |
fowles
approved these changes
Jun 3, 2021
Contributor
|
Thanks for the patch! will merge after CI finishes |
This was referenced Jun 3, 2021
bithium
pushed a commit
to bithium/protobuf
that referenced
this pull request
Sep 4, 2023
…_16.10_constinit_broken constinit not working as expected in Visual Studio 2019 Update 16.10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8688
Visual Studio 2019 Update 16.10 introduced support for
constinitfor the very first time on May 25th. Unfortunately the way how protobuf uses constinit does not work with Visual Studio msvc compiler. This is a temporary solution to unblock those who updated to latest release of Visual Studio 2019 compiler.