JS: Comply with CSP no-unsafe-eval.#8864
Merged
acozzette merged 1 commit intoprotocolbuffers:masterfrom Oct 14, 2021
marnixbouhuis:js-global-scope
Merged
JS: Comply with CSP no-unsafe-eval.#8864acozzette merged 1 commit intoprotocolbuffers:masterfrom marnixbouhuis:js-global-scope
acozzette merged 1 commit intoprotocolbuffers:masterfrom
marnixbouhuis:js-global-scope
Conversation
|
Thanks, @marnixbouhuis. |
Contributor
Author
|
Thanks for merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation uses
Function('return this')()to get the global object. This does not work if you are using protobuf on the web and you disallowunsafe-evalwith a CSP header.This PR changes the way the global object is retrieved: it calls a function and sets
thisto the global object by calling it with.call(null). Thenthisis returned.See: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/call#parameters
Note: this won't work when you are using js strict mode (
use strict).If running in strict mode, it will use different fallbacks (that work with CSP settings that disallow eval), if none work it will fall back to the current way of getting the global object.
This fixes: