Skip to content

Backport #8966 into 3.17.x#8981

Merged
acozzette merged 1 commit intoprotocolbuffers:3.17.xfrom
jtattermusch:backport_8966
Sep 23, 2021
Merged

Backport #8966 into 3.17.x#8981
acozzette merged 1 commit intoprotocolbuffers:3.17.xfrom
jtattermusch:backport_8966

Conversation

@jtattermusch
Copy link
Copy Markdown
Contributor

Backports #8966.

@acozzette
Copy link
Copy Markdown

acozzette commented Sep 22, 2021

@jtattermusch Are you sure you need this fix on the 3.17.x branch? We're probably not going to be doing any more 3.17.x releases.

@jtattermusch
Copy link
Copy Markdown
Contributor Author

@jtattermusch Are you sure you need this fix on the 3.17.x branch? We're probably going to be doing any more 3.17.x releases.

I'd say let's merge it anyway

  • Even in case we're not going to make any more 3.17.x release, the PR on the branch AFTER the release tag makes it clear that this fix in not included.
  • In case we decide to do a patch release for 3.17.x, this is going to be ready.

Btw, without this fix, the python aarch64 linux wheels we published for 3.17.x release are broken (their python_cpp layer won't work, only the pure python version will be usable) - just mentioning that to make the impact clear.

@acozzette acozzette merged commit 5500c72 into protocolbuffers:3.17.x Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants