Skip to content

Conversation

@Chan9390
Copy link
Contributor

@Chan9390 Chan9390 commented Oct 15, 2025

Context

Lighthouse supports multiple LLM providers - #8772

Description

This PR updates the frontend to support integrating different LLM providers (OpenAI, Amazon Bedrock, etc). It also replaces react-markdown with streamdown that allows better rendering of markdown.

Steps to review

temp.mp4

Checklist

API

  • Verify if API specs need to be regenerated.
  • Check if version updates are required (e.g., specs, Poetry, etc.).
  • Ensure new entries are added to CHANGELOG.md, if applicable.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2025

✅ All necessary CHANGELOG.md files have been updated.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2025

Conflict Markers Resolved

All conflict markers have been successfully resolved in this pull request.

@alejandrobailo
Copy link
Contributor

Functional review:

  • Use the same cancel button as the rest of the app.
Screenshot 2025-11-04 at 15 00 54
  • Set as default, and delete provider also must have same buttons styles as the other buttons in the app.
Screenshot 2025-11-04 at 15 01 28
  • If you add a wrong key, the error displayed is not well formatted, please use "message" key.
Screenshot 2025-11-04 at 15 02 29
  • After the error you are not able to add another key, you have to close go to the provider and edit it, this is not a correct behavior.
Screenshot 2025-11-04 at 14 59 59

Copy link
Contributor

@alejandrobailo alejandrobailo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a comment with some functional review changes that need to be addressed.

@Chan9390
Copy link
Contributor Author

Chan9390 commented Nov 4, 2025

@alejandrobailo Did the changes as follows:

  1. Updated buttons similar to those in connect cloud provider flow
image
  1. Updated button styles
image
  1. Fixing this in the API side - fix: return human readable error messages from lighthouse celery tasks #9165

After the PR is merged, the message looks as follows:

image

About this image:

image

This error occurs when the workflow errors out. There's no correct way to handle the error and display it as of now (as the error originates inside langgraph supervisor workflow). I'll try to fix it as part of a different PR.

Copy link
Contributor

@alejandrobailo alejandrobailo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no input validation, credentials are passed as Record<string, any> with no schema validation.
Use Zod to validate:

  • API key format/length
  • AWS region validity
  • Base URL format for OpenAI-compatible providers

- Migrates all lighthouse actions to use handleApiResponse/handleApiError helpers
- Introduces strict LighthouseProvider type with LIGHTHOUSE_PROVIDERS const
- Establishes consistent naming conventions (providerType for provider kinds, providerId for database UUIDs) across all lighthouse components
…atten nesting

- Remove all uses of 'any' type for full TypeScript type safety
- Create specific interfaces: LighthouseModelAttributes, LighthouseProviderAttributes, ProviderCredentialsAttributes, ProviderCredentialsResponse, ApiLinks
- Flatten interface nesting to single level for better readability
- Replace 'unknown' type with 'Record<string, string>' for credentials
- Improve type hints and IDE autocomplete support
@Chan9390 Chan9390 changed the title feat: Update Lighthouse UI feat: Update Lighthouse UI to support multi LLM Nov 7, 2025
@alejandrobailo alejandrobailo added the has-conflicts The PR has conflicts that needs to be resolved. label Nov 12, 2025
@github-actions github-actions bot removed the has-conflicts The PR has conflicts that needs to be resolved. label Nov 12, 2025
@alejandrobailo alejandrobailo merged commit 031548c into master Nov 14, 2025
31 checks passed
@alejandrobailo alejandrobailo deleted the PRWLR-7835-lighthouse-ui branch November 14, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants