-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat: Update Lighthouse UI to support multi LLM #8925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
✅ All necessary |
|
✅ Conflict Markers Resolved All conflict markers have been successfully resolved in this pull request. |
…gger background job
…r-aware credential handling
alejandrobailo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a comment with some functional review changes that need to be addressed.
|
@alejandrobailo Did the changes as follows:
After the PR is merged, the message looks as follows:
About this image:
This error occurs when the workflow errors out. There's no correct way to handle the error and display it as of now (as the error originates inside langgraph supervisor workflow). I'll try to fix it as part of a different PR. |
alejandrobailo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no input validation, credentials are passed as Record<string, any> with no schema validation.
Use Zod to validate:
- API key format/length
- AWS region validity
- Base URL format for OpenAI-compatible providers
ui/app/(prowler)/lighthouse/config/(connect-llm)/configure/page.tsx
Outdated
Show resolved
Hide resolved
- Migrates all lighthouse actions to use handleApiResponse/handleApiError helpers - Introduces strict LighthouseProvider type with LIGHTHOUSE_PROVIDERS const - Establishes consistent naming conventions (providerType for provider kinds, providerId for database UUIDs) across all lighthouse components
…atten nesting - Remove all uses of 'any' type for full TypeScript type safety - Create specific interfaces: LighthouseModelAttributes, LighthouseProviderAttributes, ProviderCredentialsAttributes, ProviderCredentialsResponse, ApiLinks - Flatten interface nesting to single level for better readability - Replace 'unknown' type with 'Record<string, string>' for credentials - Improve type hints and IDE autocomplete support








Context
Lighthouse supports multiple LLM providers - #8772
Description
This PR updates the frontend to support integrating different LLM providers (OpenAI, Amazon Bedrock, etc). It also replaces react-markdown with streamdown that allows better rendering of markdown.
Steps to review
temp.mp4
Checklist
API
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.