-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix(sharepoint): false positives on disabled external sharing #9298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sharepoint): false positives on disabled external sharing #9298
Conversation
|
✅ All necessary |
|
✅ Conflict Markers Resolved All conflict markers have been successfully resolved in this pull request. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9298 +/- ##
===========================================
+ Coverage 75.39% 88.53% +13.13%
===========================================
Files 1 93 +92
Lines 126 3505 +3379
===========================================
+ Hits 95 3103 +3008
- Misses 31 402 +371
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
🔒 Container Security ScanImage: 📊 Vulnerability Summary
2 package(s) affected
|
…o PROWLER-404-fix-sharepoint-external-sharing-false-positives
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Context
SharePoint external sharing check flagged tenants even when org-level external sharing was disabled.
Fix #9292
Description
sharepoint_external_sharing_managed.pyto treatsharingCapability == "Disabled"as aPASSbefore domain restriction evaluation, preventing false positives.sharepoint_external_sharing_managed_test.py.Steps to review
poetry run pytest tests/providers/m365/services/sharepoint/sharepoint_external_sharing_managed/sharepoint_external_sharing_managed_test.py(or full M365 suite) to verify.Checklist
UI
API
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.