-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(lighthouse): filter out non-compatible OpenAI models #9523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
✅ All necessary |
|
✅ Conflict Markers Resolved All conflict markers have been successfully resolved in this pull request. |
🔒 Container Security ScanImage: 📊 Vulnerability Summary
3 package(s) affected
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #9523 +/- ##
===========================================
+ Coverage 43.35% 92.43% +49.07%
===========================================
Files 832 159 -673
Lines 23490 22675 -815
===========================================
+ Hits 10184 20959 +10775
+ Misses 13306 1716 -11590
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
josemazo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When returning a dictionary with the key equals to the value instead of a list?
|
@josemazo OpenAI is the only provider that returns model ID and not model name. They take care of having shorter model ID. But comparing this to other providers (like Bedrock and OpenRouter, etc), they have model IDs that are not very straightforward (has versions, region info, etc) but have model names that can be displayed for the end user. So because we use : dict for other providers, for OpenAI we just pass :. |
Context
OpenAI provides lot of non-compatible LLM models. For a model to work with Lighthouse it must support text input, text output and tool calls.
Description
This PR filters out non-compatible models at the Django task level. The filtering is based on the model names.
Steps to review
Checklist
UI
API
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.