build: refactor Bazel configuration towards multiple runtime tests#160
build: refactor Bazel configuration towards multiple runtime tests#160mathetake merged 13 commits intoproxy-wasm:masterfrom
Conversation
mathetake
commented
Apr 29, 2021
mathetake
commented
- Towards tests on Add WAMR runtime #134, Add V8 and WAVM tests. #49, and Migrate runtime builds from Envoy repository to cpp-host #113
- delete variablez.bzl in favor of .bazelrc as we do in Envoy.
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
|
will add WAVM and V8 (and WAMR) builds in following PRs. |
PiotrSikora
left a comment
PiotrSikora
left a comment
There was a problem hiding this comment.
Some style changes, otherwise LGTM, thanks!
Let's merge WAMR first, since I think it's easier for us to add WAMR here, than to ask WAMR folks to catch-up with our changes again.
| ]), | ||
| deps = [ | ||
| ":common_lib", | ||
| # TODO(@mathetake): Add V8 lib. |
There was a problem hiding this comment.
FWIW, it's probably not worth spending time too much time on getting V8 to build, and we can wait until Bazel is officially supported in V8.
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
| ]), | ||
| deps = [ | ||
| ":common_lib", | ||
| # TODO(@mathetake): Add WAMR lib. |
There was a problem hiding this comment.
Any chance you could try to add WAMR here? Or do you prefer to leave it for a separate PR?
There was a problem hiding this comment.
I will do in a separate PR.
| ]), | ||
| deps = [ | ||
| ":common_lib", | ||
| # TODO(@mathetake): Add WAVM lib. |
There was a problem hiding this comment.
Any chance you could try to add WAVM here? Or do you prefer to leave it for a separate PR?
There was a problem hiding this comment.
I will do in a separate PR.
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
| # See https://bytecodealliance.github.io/wasmtime/c-api/ | ||
| build:linux --linkopt=-lm | ||
| build:linux --linkopt=-lpthread | ||
| build:linux --linkopt=-ldl |
There was a problem hiding this comment.
This .bazelrc only applies to builds in this workspace.
Shouldn't those linkopts be a part of wasmtime_lib, so that other applications that link against it could pick up them up? But even then, I think the embedding binary would need to specify them as well...
There was a problem hiding this comment.
Actually, let's deal with this once it becomes a problem.
There was a problem hiding this comment.
yeah, thanks for pointing this out. I will keep that in mind.
PiotrSikora
left a comment
PiotrSikora
left a comment
There was a problem hiding this comment.
Could you verify that this PR doesn't accidentally break Envoy build before merging? Thanks!
| # See https://bytecodealliance.github.io/wasmtime/c-api/ | ||
| build:linux --linkopt=-lm | ||
| build:linux --linkopt=-lpthread | ||
| build:linux --linkopt=-ldl |
There was a problem hiding this comment.
Actually, let's deal with this once it becomes a problem.
|
just verified that Envoy can be built normally against this branch. Now merging. Thanks! |
2 participants
