build: enable WAMR and WAVM runtimes. by mathetake · Pull Request #162 · proxy-wasm/proxy-wasm-cpp-host

mathetake · 2021-05-11T07:45:27Z

Signed-off-by: Takeshi Yoneda takeshi@tetrate.io

partially resolves_ #49 and left TODO in #142

bazel/external/llvm.BUILD

PiotrSikora · 2021-05-11T09:44:47Z

Could you add WAVM while you're at it? Once you get LLVM working, that should be pretty easy.

Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>

.bazelrc

Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>

bazel/external/llvm.BUILD

.bazelrc

bazel/external/wavm.BUILD

Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>

bazel/external/llvm.patch

bazel/external/wamr.BUILD

Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>

mathetake · 2021-05-13T01:51:47Z

~~so working on the test fixes, but I encountered some weird bug around contexts with WAVM.. which I think is something to do with the previous nasty bug we fought last year.. envoyproxy/envoy@8d49c1d~~ Fixed.

Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>

src/wavm/wavm.cc

.github/workflows/cpp.yml

Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>

test/runtime_test.cc

mathetake · 2021-05-13T07:28:51Z

OK WAMR and Wasmtime finishes in 1~2 min so the cache works fine :)

Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>

test/runtime_test.cc

.github/workflows/cpp.yml

Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>

PiotrSikora

LGTM, sans nits.

test/runtime_test.cc

.github/workflows/cpp.yml

PiotrSikora · 2021-05-14T07:05:08Z

I'm not sure why the builds fails now.

There is this warning in logs:

stdout (/home/runner/.cache/bazel/_bazel_runner/ae21fb6b2e26a9267f16b46bb90ea321/execroot/proxy_wasm_cpp_host/bazel-out/_tmp/actions/stdout-69) exceeds maximum size of --experimental_ui_max_stdouterr_bytes=1048576 bytes; skipping

so maybe remove build_args = ["-v"]? It doesn't look like a failure, but there is nothing else of significance in the logs.

Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>

bazel/external/llvm.BUILD

Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>

test/runtime_test.cc

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

PiotrSikora

LGTM, assuming that raw_context -> current_context_ change is intentional and needed.

Thanks!

(Envoy tests for this PR are running in envoyproxy/envoy#16430)

.github/workflows/cpp.yml

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

.github/workflows/cpp.yml

mathetake force-pushed the llvm-wamr branch from 5a466aa to f0696bf Compare May 11, 2021 08:14

PiotrSikora reviewed May 11, 2021

View reviewed changes

bazel/external/llvm.BUILD Outdated Show resolved Hide resolved

build: enable WAMR and LLVM builds.

9337c10

Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>

mathetake force-pushed the llvm-wamr branch from f0696bf to 9337c10 Compare May 12, 2021 04:32

mathetake added 2 commits May 12, 2021 14:13

Add WAVM.

fe09128

Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>

Use clang.

26a0890

Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>

mathetake force-pushed the llvm-wamr branch from 077bf23 to 26a0890 Compare May 12, 2021 05:14

mathetake changed the title ~~build: enable WAMR and LLVM builds.~~ build: enable WAMR and WAVM builds. May 12, 2021

mathetake changed the title ~~build: enable WAMR and WAVM builds.~~ build: enable WAM, WAVM and LLVM builds. May 12, 2021

mathetake changed the title ~~build: enable WAM, WAVM and LLVM builds.~~ build: enable WAMR, WAVM and LLVM builds. May 12, 2021

Fix test path

8357bea

Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>

PiotrSikora reviewed May 12, 2021

View reviewed changes

.bazelrc Outdated Show resolved Hide resolved

mathetake added 4 commits May 12, 2021 16:57

Cache on runtime dependency versions.

9d15fb0

Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>

Fix WAVM build and disable runtime_test temporarily.

8296f8e

Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>

Fix bazelrc.

cf4978d

Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>

Fix runtime name.

0e077c4

Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>

PiotrSikora reviewed May 12, 2021

View reviewed changes

bazel/external/llvm.BUILD Show resolved Hide resolved

.bazelrc Show resolved Hide resolved

bazel/external/wavm.BUILD Outdated Show resolved Hide resolved

bazel/external/wavm.BUILD Outdated Show resolved Hide resolved

mathetake added 2 commits May 13, 2021 00:03

review: add Ninja options.

5770ad4

Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>

Merge remote-tracking branch 'origin/master' into llvm-wamr

6abbc2d

PiotrSikora reviewed May 12, 2021

View reviewed changes

bazel/external/llvm.patch Outdated Show resolved Hide resolved

PiotrSikora reviewed May 12, 2021

View reviewed changes

bazel/external/wamr.BUILD Outdated Show resolved Hide resolved

mathetake added 2 commits May 13, 2021 09:41

review: remove deprecated options, LLVM patch.

c67261f

Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>

Use cache@v2 for better compression

117534a

Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>

Fix runtime tests.

db4b0ce

Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>

mathetake marked this pull request as ready for review May 13, 2021 03:19

mathetake commented May 13, 2021

View reviewed changes

src/wavm/wavm.cc Show resolved Hide resolved

mathetake commented May 13, 2021

View reviewed changes

.github/workflows/cpp.yml Outdated Show resolved Hide resolved

Fix WAVM build with unresolved TODO.

180cfd0

Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>

mathetake commented May 13, 2021

View reviewed changes

test/runtime_test.cc Show resolved Hide resolved

mathetake added 4 commits May 13, 2021 21:09

review: use simple cache key.

72a8153

Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>

Update WAMR and use Ninja.

f3d9496

Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>

review: Delete trap2 test.

90dc748

Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>

Add missing header in NullVm.

0bb696f

Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>

PiotrSikora reviewed May 13, 2021

View reviewed changes

test/runtime_test.cc Show resolved Hide resolved

test/runtime_test.cc Outdated Show resolved Hide resolved

PiotrSikora reviewed May 13, 2021

View reviewed changes

.github/workflows/cpp.yml Show resolved Hide resolved

mathetake added 2 commits May 14, 2021 08:40

review: restore seprate trap2 test with TODO for WAVM and fix nits.

cb274d3

Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>

Merge remote-tracking branch 'origin/master' into llvm-wamr

86002c8

PiotrSikora reviewed May 14, 2021

View reviewed changes

test/runtime_test.cc Outdated Show resolved Hide resolved

test/runtime_test.cc Show resolved Hide resolved

.github/workflows/cpp.yml Outdated Show resolved Hide resolved

.github/workflows/cpp.yml Outdated Show resolved Hide resolved

mathetake added 2 commits May 14, 2021 17:24

review: fix style.

6fed6fe

Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>

try removing -v.

502c42e

Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>

PiotrSikora reviewed May 14, 2021

View reviewed changes

bazel/external/llvm.BUILD Show resolved Hide resolved

review: disable LLVM benchmark build.

7492878

Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>

PiotrSikora reviewed May 15, 2021

View reviewed changes

test/runtime_test.cc Show resolved Hide resolved

PiotrSikora added 2 commits May 14, 2021 21:28

Merge branch 'master' into llvm-wamr

cb4a607

Fix merge (missing new line at the end).

7822e89

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

PiotrSikora changed the title ~~build: enable WAMR, WAVM and LLVM builds.~~ build: enable WAMR and WAVM runtimes. May 15, 2021

PiotrSikora approved these changes May 15, 2021

View reviewed changes

PiotrSikora requested changes May 15, 2021

View reviewed changes

.github/workflows/cpp.yml Show resolved Hide resolved

PiotrSikora added 2 commits May 15, 2021 02:15

review: use --per_file_copt.

d6ba6ab

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

review: wipe cache.

6cf8d7b

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

PiotrSikora approved these changes May 15, 2021

View reviewed changes

.github/workflows/cpp.yml Show resolved Hide resolved

mathetake merged commit 21af4d7 into proxy-wasm:master May 16, 2021

mathetake deleted the llvm-wamr branch May 16, 2021 22:53

mathetake mentioned this pull request Jun 7, 2021

CI: use non-static cache key for Bazel #108

Closed

Conversation

mathetake commented May 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

PiotrSikora commented May 11, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mathetake commented May 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mathetake commented May 13, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PiotrSikora left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PiotrSikora commented May 14, 2021

Uh oh!

Uh oh!

Uh oh!

PiotrSikora left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mathetake commented May 11, 2021 •

edited

Loading

mathetake commented May 13, 2021 •

edited

Loading