Add enum names before items#430
Closed
victorgomes wants to merge 1 commit intoproxy-wasm:mainfrom
Closed
Conversation
Author
|
@leonm1 PTAL! |
Signed-off-by: Victor Gomes <victorgomes@chromium.org>
leonm1
approved these changes
Mar 4, 2025
mpwarres
approved these changes
Mar 5, 2025
Contributor
|
Does this not require updating the v8 version? proxy-wasm-cpp-host/bazel/repositories.bzl Lines 171 to 183 in c4d7bb0 |
Author
|
This initial change doesn't require a V8 update. I was planning further work ... However, the current V8 version is approximately three years old. Updating V8 would significantly impact this PR, and the required effort is too large. Therefore, I'm abandoning this PR and will instead patch via copybara in g3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
V8 now uses enum classes.
Context: https://chromium-review.googlesource.com/c/v8/v8/+/6087801