Closed
Conversation
mmorel-35
requested review from
PiotrSikora,
leonm1,
martijneken and
mpwarres
as code owners
mpwarres
approved these changes
Dec 2, 2025
Contributor
mpwarres
left a comment
mpwarres
left a comment
There was a problem hiding this comment.
Thanks! Looks like this will bring us into sync with the version Envoy is using, which is good.
Contributor
|
It looks like this line needs to be removed: proxy-wasm-cpp-host/bazel/wasm.bzl Line 67 in c8868da Can you commit this? |
mmorel-35
force-pushed
the
bazel-7.7.1
branch
2 times, most recently
from
e4e83e4 to
e76f0c5
Compare
Contributor
|
Thanks for the work on making clang-tidy work! I couldn't get it to work myself. I look forward to merging this once status checks pass. |
mmorel-35
force-pushed
the
bazel-7.7.1
branch
2 times, most recently
from
0673b86 to
49b34a8
Compare
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
…ing aspect_rules_lint Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
mmorel-35
force-pushed
the
bazel-7.7.1
branch
from
49b34a8 to
e1a5f35
Compare
Contributor
|
I anticipate we can fix the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bump Bazel to v7.7.1