Capture standard error when shelling out to git#5
Open
davidbalbert wants to merge 2 commits intopry:masterfrom
Open
Capture standard error when shelling out to git#5davidbalbert wants to merge 2 commits intopry:masterfrom
davidbalbert wants to merge 2 commits intopry:masterfrom
Conversation
Also better error messages
Author
|
I also included a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
find_git_rootchecks stdout for error messages, but error messages are printed to standard error. Thus we get an exception later on in the code because the error check failed. Here's what currently happens:The "fatal line is git's standard error, the next two lines are from later because of the broken error check.
With this fix, the output becomes: