Skip to content

[BUG] Failed download causes crash #13

@pryrt

Description

@pryrt

@ozone10 had a crash report:

CollectionInterface plugin will crash notepad++ after dismissing message box with error that connection is blocked.

with further details:

here is quick "static" analyses

std::vector<char> vcThemeJSON = downloadFileInMemory(L"https://raw.githubusercontent.com/notepad-plus-plus/nppThemes/master/themes/.toc.json");

You don't check if downloadFileInMemory returns empty vector which will I think cause issue for next 2 lines 245-246.

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingcrashthis issue can cause a crash

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions