Swap char for int to fix arg parsing on systems where char is unsigned#45
Merged
uyjulian merged 1 commit intops2dev:masterfrom Jan 10, 2026
Merged
Swap char for int to fix arg parsing on systems where char is unsigned#45uyjulian merged 1 commit intops2dev:masterfrom
uyjulian merged 1 commit intops2dev:masterfrom
Conversation
Member
|
LGTM thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On certain systems (notably ARM64?)
charmight not necessarily be signed. This causes issues when ps2-packer tries to read arguments as it can't check forEOFproperly.This PR changes the data type of the variable used to store the value returned from getopt to an
int, which fixes argument parsing on these systems.Fixes #43