-
Notifications
You must be signed in to change notification settings - Fork 68
Add access() function #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I almost forgot, for this change to work, there's also a required change in the in struct __syscalls_t {
...
int (*access_r)(struct _reent *r,const char *name,int mode);
...
}Right now the ps3toolchain uses a newlib patch from: https://github.com/ps3dev/ps3toolchain/blob/master/patches/newlib-1.20.0-PS3.patch I assume this change should be added there, but I'm not sure what's the proper way to include it (Perhaps this PR should be reverted until the other change is discussed and committed) |
|
@bucanero you can make the PR to the toolchain EDIT: |
|
thanks @miigotu ! 👍 I went to bed last night and I couldn't submit the missing patch thanks again for your help! 😄 |
|
@miigotu , today doing a full rebuild I realized that some additional code was needed in the newlib patch to add the I've submitted a PR here: ps3dev/ps3toolchain#90 |
|
I guess that's why the build was failing. I saw that it wasn't added in my PR but I wasn't sure if it needed added there too. Keep up the good work. |
|
let me know if your auto-build works after this PR. |
|
Autobuild is failing because ftp.gnu.org has rate limiting and the scrit tries to download the archives 4 times lol. I'll get it figured out. |
|
that reminds me of a time I couldn't build the ps3 tools and it was because |
|
I'm going to see about adding them as submodules or use repo. Git has come a long way with submodules since we wrote the toolchain and tried submodules over 10 years ago ;) |
With information from https://www.psdevwiki.com/ps3/LV2_Functions_and_Syscalls , I added
sysLv2FsAccessandaccess(const char *path, int mode)functions.