Skip to content

Allow to specify no dev or ignore platform#17

Merged
muglug merged 1 commit intopsalm:masterfrom
Nyholm:issue-16
Oct 28, 2020
Merged

Allow to specify no dev or ignore platform#17
muglug merged 1 commit intopsalm:masterfrom
Nyholm:issue-16

Conversation

@Nyholm
Copy link
Copy Markdown
Contributor

@Nyholm Nyholm commented Oct 27, 2020

@muglug muglug merged commit e59b271 into psalm:master Oct 28, 2020
@muglug
Copy link
Copy Markdown
Member

muglug commented Oct 28, 2020

Thanks!

@Nyholm Nyholm deleted the issue-16 branch October 28, 2020 06:54
@Nyholm
Copy link
Copy Markdown
Contributor Author

Nyholm commented Oct 28, 2020

Thank you for merging

@nederdirk
Copy link
Copy Markdown

Oof, this broke our build (https://github.com/marketphase) pretty hard, since the default suddenly changed from 'install including dev-dependencies' to 'install excluding dev-dependencies' 😿

@Nyholm
Copy link
Copy Markdown
Contributor Author

Nyholm commented Nov 6, 2020

Im sorry about that.

Did you see how to get back the old behaviour?

+     env:
+       REQUIRE_DEV: true

@nederdirk
Copy link
Copy Markdown

Im sorry about that.

Did you see how to get back the old behaviour?

+     env:
+       REQUIRE_DEV: true

thanks! I added that to our downstream docker image (we need some PHP exts, so we're building on this one)

simPod added a commit to simPod/psalm-github-actions that referenced this pull request Nov 16, 2020
This was referenced Nov 16, 2020
franmomu added a commit to franmomu/persistence that referenced this pull request Nov 18, 2020
After psalm/psalm-github-actions#17, we
need to use a variable to be able to install dev packages before
executing psalm.
franmomu added a commit to franmomu/persistence that referenced this pull request Nov 18, 2020
After psalm/psalm-github-actions#17, we
need to use a variable to be able to install dev packages before
executing psalm. This variable was renamed in psalm/psalm-github-actions@0b419a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Be able to use it with PHP extensions

3 participants