Const-seed rng #366
Merged
Const-seed rng #366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germasch
approved these changes
Nov 21, 2025
Contributor
germasch
left a comment
germasch
left a comment
There was a problem hiding this comment.
LGTM.
As I'm looking at the code, I'm wondering if it wouldn't be better to have these as singletons, though. Since there's, I suppose, one ProcessGenerator per process, singleton would seem appropriate ;) I think the implementation already actually follows the singleton pattern, but then it seems unnecessary to make a shared_ptr, since the use count will never go back down to zero, anyway.
enables manual seeding
JamesMcClung
force-pushed
the
pr/const-seed-rng
branch
from
ca4637e to
680d0a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hacky way to seed rngs with constant values. Useful for e.g. initializing the same realization of magnetic turbulence across all processes.