feat: Add /debug, /refactor, /deps skills; npm→bun migration; fix agent frontmatter#40
Conversation
…agent frontmatter (psd-coding-system) New skills (3): - /debug — structured debugging workflow: reproduce, isolate, diagnose, fix with mandatory regression tests and learning capture via learning-writer agent. Dispatches domain specialists based on bug type. - /refactor — safe refactoring with breaking-change-validator integration, test baseline comparison, and behavior preservation verification. Dispatches code-simplicity-reviewer for readability validation. - /deps — dependency audit for CVEs, outdated packages, and license compliance across bun/npm/pip/cargo. Risk-assessed recommendations with separate audit/update/outdated modes. npm → bun migration (20 files): - Replaced npm as primary package manager with bun across all agents and skills: npm run → bun run, npm test → bun test, npm audit → bun audit, npm ci → bun install --frozen-lockfile, npx → bunx - Core workflow skills updated: /work, /lfg, /review-pr, /test, /security-audit - Supplementary files updated: test-runner.md, security-scan.md - Agent files updated: test-specialist, frontend-specialist, documentation-writer, breaking-change-validator, security-analyst, security-analyst-specialist, deployment-verification-agent, repo-research-analyst - Kept npm as fallback in multi-runtime chains (bun test || npm test) - Preserved generic OWASP examples unchanged (framework-agnostic) Agent frontmatter fixes (5 agents missing tools field): - domain/architect-specialist: added tools: Read, Grep, Glob, WebSearch - domain/shell-devops-specialist: added tools: Bash, Read, Edit, Write, Grep, Glob - validation/telemetry-data-specialist: added tools: Bash, Read, Grep, Glob - validation/plan-validator: added tools: Read, Grep, Glob, WebSearch - validation/configuration-validator: added tools: Bash, Read, Grep, Glob
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces new debugging, refactoring, and dependency management skills, migrates the project to use Bun as the primary package manager, and updates agent configurations. These changes aim to improve the development workflow, enhance security, and ensure better tool integration across the system. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces three new skills (/debug, /refactor, /deps), migrates the project from npm to bun as the primary package manager, and adds missing tools frontmatter to several agents. The changes are extensive and well-structured.
My review focused on the correctness of the npm-to-bun migration and the implementation of the new skills. I've identified a couple of minor areas for improvement:
- An unused
strategyblock in a GitHub Actions workflow after the migration. - A potentially misleading fallback command in the new
/depsskill.
Overall, this is a solid contribution that modernizes the project's tooling and expands its capabilities. The new skills are well-documented and follow a clear, phased approach.
| strategy: | ||
| matrix: | ||
| node-version: [16, 18, 20] | ||
|
|
| echo "=== Security Vulnerabilities ===" | ||
|
|
||
| if [ "$PKG_MANAGER" = "bun" ]; then | ||
| bun audit 2>&1 || bun pm ls 2>&1 | head -30 |
There was a problem hiding this comment.
The fallback command bun pm ls is not a security audit tool and does not provide relevant information if bun audit fails. If bun audit fails, its error output should be captured and analyzed, which is the default behavior of the shell. The fallback to listing packages can be misleading and should be removed.
| bun audit 2>&1 || bun pm ls 2>&1 | head -30 | |
| bun audit 2>&1 |
Summary
/debug(structured debugging workflow),/refactor(safe refactoring with breaking-change-validator),/deps(dependency audit for CVEs and outdated packages)toolsfield to architect-specialist, shell-devops-specialist, telemetry-data-specialist, plan-validator, configuration-validatorDetails
New Skills
/debug/refactor/depsnpm → bun Files Changed
Agents (9): test-specialist, frontend-specialist, documentation-writer, breaking-change-validator, security-analyst, security-analyst-specialist, deployment-verification-agent, repo-research-analyst, document-validator
Skills (7): /work, /lfg, /review-pr, /test, /security-audit, test-runner.md, security-scan.md
Generic OWASP examples preserved unchanged (framework-agnostic).
Agent Frontmatter
Test plan
/debug "test error"on a project with failing tests — verify it follows the reproduce→diagnose→fix flow/refactor "extract module"— verify it establishes test baseline before changes/depson a Node project — verify it detects package manager and runs audit/workor/test— verify bun is used as primary runnertoolsfield still dispatch correctly from skills🤖 Generated with Claude Code