Skip to content

feat: Add /debug, /refactor, /deps skills; npm→bun migration; fix agent frontmatter#40

Open
james-cantonwine wants to merge 1 commit into
psd401:mainfrom
james-cantonwine:feat/bun-migration-new-skills
Open

feat: Add /debug, /refactor, /deps skills; npm→bun migration; fix agent frontmatter#40
james-cantonwine wants to merge 1 commit into
psd401:mainfrom
james-cantonwine:feat/bun-migration-new-skills

Conversation

@james-cantonwine
Copy link
Copy Markdown

Summary

  • 3 new skills: /debug (structured debugging workflow), /refactor (safe refactoring with breaking-change-validator), /deps (dependency audit for CVEs and outdated packages)
  • npm → bun migration: Replaced npm as primary package manager with bun across 20 files (agents + skills). Bun is primary, npm kept as fallback in multi-runtime chains.
  • 5 agent frontmatter fixes: Added missing tools field to architect-specialist, shell-devops-specialist, telemetry-data-specialist, plan-validator, configuration-validator

Details

New Skills

Skill Purpose
/debug Reproduce → isolate → diagnose → fix with mandatory regression tests and learning capture
/refactor Test baseline → breaking-change analysis → incremental refactor → behavior verification
/deps Security audit, outdated check, risk assessment across bun/npm/pip/cargo

npm → bun Files Changed

Agents (9): test-specialist, frontend-specialist, documentation-writer, breaking-change-validator, security-analyst, security-analyst-specialist, deployment-verification-agent, repo-research-analyst, document-validator

Skills (7): /work, /lfg, /review-pr, /test, /security-audit, test-runner.md, security-scan.md

Generic OWASP examples preserved unchanged (framework-agnostic).

Agent Frontmatter

Agent Added tools
architect-specialist Read, Grep, Glob, WebSearch
shell-devops-specialist Bash, Read, Edit, Write, Grep, Glob
telemetry-data-specialist Bash, Read, Grep, Glob
plan-validator Read, Grep, Glob, WebSearch
configuration-validator Bash, Read, Grep, Glob

Test plan

  • Run /debug "test error" on a project with failing tests — verify it follows the reproduce→diagnose→fix flow
  • Run /refactor "extract module" — verify it establishes test baseline before changes
  • Run /deps on a Node project — verify it detects package manager and runs audit
  • Run /work or /test — verify bun is used as primary runner
  • Verify agents with new tools field still dispatch correctly from skills

🤖 Generated with Claude Code

…agent frontmatter (psd-coding-system)

New skills (3):
- /debug — structured debugging workflow: reproduce, isolate, diagnose,
  fix with mandatory regression tests and learning capture via
  learning-writer agent. Dispatches domain specialists based on bug type.
- /refactor — safe refactoring with breaking-change-validator integration,
  test baseline comparison, and behavior preservation verification.
  Dispatches code-simplicity-reviewer for readability validation.
- /deps — dependency audit for CVEs, outdated packages, and license
  compliance across bun/npm/pip/cargo. Risk-assessed recommendations
  with separate audit/update/outdated modes.

npm → bun migration (20 files):
- Replaced npm as primary package manager with bun across all agents
  and skills: npm run → bun run, npm test → bun test, npm audit →
  bun audit, npm ci → bun install --frozen-lockfile, npx → bunx
- Core workflow skills updated: /work, /lfg, /review-pr, /test,
  /security-audit
- Supplementary files updated: test-runner.md, security-scan.md
- Agent files updated: test-specialist, frontend-specialist,
  documentation-writer, breaking-change-validator, security-analyst,
  security-analyst-specialist, deployment-verification-agent,
  repo-research-analyst
- Kept npm as fallback in multi-runtime chains (bun test || npm test)
- Preserved generic OWASP examples unchanged (framework-agnostic)

Agent frontmatter fixes (5 agents missing tools field):
- domain/architect-specialist: added tools: Read, Grep, Glob, WebSearch
- domain/shell-devops-specialist: added tools: Bash, Read, Edit, Write, Grep, Glob
- validation/telemetry-data-specialist: added tools: Bash, Read, Grep, Glob
- validation/plan-validator: added tools: Read, Grep, Glob, WebSearch
- validation/configuration-validator: added tools: Bash, Read, Grep, Glob
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces new debugging, refactoring, and dependency management skills, migrates the project to use Bun as the primary package manager, and updates agent configurations. These changes aim to improve the development workflow, enhance security, and ensure better tool integration across the system.

Highlights

  • New Skills: Introduced three new skills: /debug for structured debugging, /refactor for safe refactoring, and /deps for dependency auditing.
  • npm to Bun Migration: Migrated from npm to bun as the primary package manager across various agent and skill files, while keeping npm as a fallback.
  • Agent Frontmatter Fixes: Added missing tools field to the frontmatter of several agent files, enhancing their functionality.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces three new skills (/debug, /refactor, /deps), migrates the project from npm to bun as the primary package manager, and adds missing tools frontmatter to several agents. The changes are extensive and well-structured.

My review focused on the correctness of the npm-to-bun migration and the implementation of the new skills. I've identified a couple of minor areas for improvement:

  • An unused strategy block in a GitHub Actions workflow after the migration.
  • A potentially misleading fallback command in the new /deps skill.

Overall, this is a solid contribution that modernizes the project's tooling and expands its capabilities. The new skills are well-documented and follow a clear, phased approach.

Comment on lines 371 to +374
strategy:
matrix:
node-version: [16, 18, 20]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The strategy block with the node-version matrix is no longer used since migrating to setup-bun. It should be removed to avoid confusion and improve the clarity of the workflow.

echo "=== Security Vulnerabilities ==="

if [ "$PKG_MANAGER" = "bun" ]; then
bun audit 2>&1 || bun pm ls 2>&1 | head -30
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The fallback command bun pm ls is not a security audit tool and does not provide relevant information if bun audit fails. If bun audit fails, its error output should be captured and analyzed, which is the default behavior of the shell. The fallback to listing packages can be misleading and should be removed.

Suggested change
bun audit 2>&1 || bun pm ls 2>&1 | head -30
bun audit 2>&1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant