Support py38-style starred expressions in return statement#1121
Merged
JelleZijlstra merged 5 commits intopsf:masterfrom Jan 18, 2020
Merged
Support py38-style starred expressions in return statement#1121JelleZijlstra merged 5 commits intopsf:masterfrom
JelleZijlstra merged 5 commits intopsf:masterfrom
Conversation
Contributor
Author
|
Fixed |
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Jan 23, 2020
Note: black cannot parse `return *active_fixture_argnames, *self.argnames` yet (fixed in master, psf/black#1121). Tested manually using: ```python @pytest.fixture(scope="session") def xdist_suffix(request): print("\nxdist_suffix") suffixes.append("xdist") @pytest.fixture(scope="session") def parallel_suffix(tox_suffix, xdist_suffix): pass def test_suffix(parallel_suffix): assert suffixes == ["tox", "xdist"] ``` When using a set there the order is not deterministic, i.e. the test is flaky.
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Jan 25, 2020
Note: black cannot parse `return *active_fixture_argnames, *self.argnames` yet (fixed in master, psf/black#1121). Tested manually using: ```python @pytest.fixture(scope="session") def xdist_suffix(request): print("\nxdist_suffix") suffixes.append("xdist") @pytest.fixture(scope="session") def parallel_suffix(tox_suffix, xdist_suffix): pass def test_suffix(parallel_suffix): assert suffixes == ["tox", "xdist"] ``` When using a set there the order is not deterministic, i.e. the test is flaky.
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Mar 9, 2020
Note: black cannot parse `return *active_fixture_argnames, *self.argnames` yet (fixed in master, psf/black#1121). Tested manually using: ```python @pytest.fixture(scope="session") def xdist_suffix(request): print("\nxdist_suffix") suffixes.append("xdist") @pytest.fixture(scope="session") def parallel_suffix(tox_suffix, xdist_suffix): pass def test_suffix(parallel_suffix): assert suffixes == ["tox", "xdist"] ``` When using a set there the order is not deterministic, i.e. the test is flaky.
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Mar 31, 2020
Note: black cannot parse `return *active_fixture_argnames, *self.argnames` yet (fixed in master, psf/black#1121). Tested manually using: ```python @pytest.fixture(scope="session") def xdist_suffix(request): print("\nxdist_suffix") suffixes.append("xdist") @pytest.fixture(scope="session") def parallel_suffix(tox_suffix, xdist_suffix): pass def test_suffix(parallel_suffix): assert suffixes == ["tox", "xdist"] ``` When using a set there the order is not deterministic, i.e. the test is flaky.
This was referenced Mar 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
#1091
Support
py38starred expressions inreturnandyieldstatements. Bug descriptionInvestigation
Event the newest plib2to3 grammar does not support starred expressions in return statements, so switching to a new version will not solve the issue.
The idea is to use
return_stmt: 'return' [testlist_star_expr]inGrammar.txtto support both old and new return statements.Changes
return_stmtyield_stmttest_python38Not done
Featureso it does not require--target-version=py38, as it is more of a bug