Skip to content

Remove for brackets: Extra unit test #2953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jpy-git wants to merge 2 commits into from
Closed

Remove for brackets: Extra unit test #2953

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35f5d8f
Remove for brackets: Extra unit test
jpy-git Mar 24, 2022
a2d1d19
Caveat on test case
jpy-git Mar 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions tests/data/remove_for_brackets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@
for (k, v) in dfkasdjfldsjflkdsjflkdsjfdslkfjldsjfgkjdshgkljjdsfldgkhsdofudsfudsofajdslkfjdslkfjldisfjdffjsdlkfjdlkjjkdflskadjldkfjsalkfjdasj.items():
print(k, v)

# Multiple brackets (N.B. this only currently works due to the second pass.
# We should fix this to work in one pass.
for ((((k, v)))) in d.items():
print(k, v)

# output
# Only remove tuple brackets after `for`
for k, v in d.items():
Expand All @@ -38,3 +43,8 @@
dfkasdjfldsjflkdsjflkdsjfdslkfjldsjfgkjdshgkljjdsfldgkhsdofudsfudsofajdslkfjdslkfjldisfjdffjsdlkfjdlkjjkdflskadjldkfjsalkfjdasj.items()
):
print(k, v)

# Multiple brackets (N.B. this only currently works due to the second pass.
# We should fix this to work in one pass.
for k, v in d.items():
print(k, v)