Skip to content

Fix an issue where extra empty lines are added.#3470

Merged
JelleZijlstra merged 2 commits into
psf:mainfrom
yilei:fmtskip
Dec 21, 2022
Merged

Fix an issue where extra empty lines are added.#3470
JelleZijlstra merged 2 commits into
psf:mainfrom
yilei:fmtskip

Conversation

@yilei
Copy link
Copy Markdown
Contributor

@yilei yilei commented Dec 20, 2022

Description

Fixes #3454.

This is actually unrelated to # fmt: skip, as this also happens when a regular standalone comment is placed between decorators.

This is a regression caused by #3302 (Preview.empty_lines_before_class_or_def_with_leading_comments)

Checklist - did you ...

  • Add an entry in CHANGES.md if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

@github-actions
Copy link
Copy Markdown
Contributor

diff-shades reports zero changes comparing this PR (aae8b4d) to main (59f03d1).


What is this? | Workflow run | diff-shades documentation

@JelleZijlstra JelleZijlstra merged commit 29dd257 into psf:main Dec 21, 2022
hugovk pushed a commit to hugovk/black that referenced this pull request Jan 16, 2023
@yilei yilei deleted the fmtskip branch January 24, 2023 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extra newlines added before function with fmt skip on decorator

2 participants