not enforcing python3.6 for precommit hook

[miki725]

this should allow precommit hooks to be used with py37

[coveralls]

Pull Request Test Coverage Report for Build 599

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 96.003%

---

Totals
Change from base Build 590:	0.0%
Covered Lines:	2618
Relevant Lines:	2727

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 599

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 96.003%

---

Totals
Change from base Build 590:	0.0%
Covered Lines:	2618
Relevant Lines:	2727

---

💛 - Coveralls

[asottile]

Either value here is fine.

This is overridable in the local .pre-commit-config.yaml:

-   repo: https://github.com/ambv/black
    rev: ...  # fill this out!
    hooks:
    -   id: black
        language_version: python3  # or python3.7 or whatever you like!

[ambv]

I understand that the problem is that we should be using Python 3.7 instead. However, the change as is will inevitably end with somebody getting Python 3.5 and then complaining here. Anthony, any way we can specify minimum version?

[miki725]

dont think you can specify ranges in pre-commit itself - https://pre-commit.com/#overriding-language-version

black itself though enforces python version in setup.py via python_requires . If someone will attempt to use precommit with older python, black will fail to install. Dont have older py3 version installed so cant test for certain.

https://github.com/ambv/black/blob/3fb451687293c993b10d860449eb405ddd44f377/setup.py#L42

[asottile]

Not currently, pre-commit itself doesn't actually know or care about the values of language_version and just passes them through to the underlying tool (virtualenv / nodeenv / rbenv / etc.).

tbh, language_verison: python3 and then docs about requiring python3.6 and how to set that probably makes the most sense. At least for macos we've had to override this in our repositories to language_verison: python3

[ambv]

@miki725 is right, Black will just fail to install on an old Python 3 so we're good anyway. Let's have this.

[ambv]

Thanks! ✨ 🍰 ✨

[miki725]

no problem. glad to help, at least in some small way. and thanks for merging!

btw the project is awesome!!! thanks for sharing it with everyone