Fix 4399 ASTSafetyError on comment in return type annotation#4444
Closed
dankrzeminski32 wants to merge 4 commits into
Closed
Fix 4399 ASTSafetyError on comment in return type annotation#4444dankrzeminski32 wants to merge 4 commits into
ASTSafetyError on comment in return type annotation#4444dankrzeminski32 wants to merge 4 commits into
Conversation
hauntsaninja
reviewed
Sep 8, 2024
Collaborator
hauntsaninja
left a comment
There was a problem hiding this comment.
Thank you for the PR!
I have a slightly different fix in mind. We should try and find a leaf that actually has the appropriate parent set. This will fix a similar crash in another case, see:
def foo() -> (
# comment inside parenthesised new union return type
int | str | bytes
):
...
I opened a PR with what I had in mind at #4453. I'd be grateful if you had time to take a look and see if it makes sense to you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #4399
Added an extra check before adding commas to the elements in the body of a bracket split.
The check ensures that there is more than just one non-comment item in the list of return elements. It only performs this check for a bracket split in return annotations as it's non-problematic for parameter annotations.
The extra comment was causing the
ASTSafetyError(it led to the return type being interpreted as a tuple).Checklist - did you ...
CHANGES.mdif necessary?