switch from lockfile to filelock#283
Closed
dimbleby wants to merge 1 commit intopsf:masterfrom
dimbleby:lockfile-filelock
Closed
switch from lockfile to filelock#283dimbleby wants to merge 1 commit intopsf:masterfrom dimbleby:lockfile-filelock
dimbleby wants to merge 1 commit intopsf:masterfrom
dimbleby:lockfile-filelock
Conversation
lockfile has long been deprecated, among the advantages of filelock are that locks are automatically released on process exit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I see that this project is rather inactive, but I guess I'm an optimist...
lockfile has long been deprecated, per #109 (2016!). #114 was an earlier try at getting cachecontrol onto something that was both active and better, it went with fasteners. These days filelock is getting about ten times as many downloads as fasteners - so I've used that.
Among the ways that this fixes actual bugs - ie is not just change for its own sake - is that the mechanisms used by filelock will automatically release the lock if the process exits early eg by Ctrl-C or bug or whatever.