Conversation
Author
|
I'm not quite sure what happened to the checks. Seems like the macOS build has timed out? It simply says Any idea what I could do to fix that? |
|
Some of the test runs have been a bit flaky. Not sure what the deal is. Thanks for your PRs though! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #10
To make everything work I needed to make three changes (explained below). I would say that all three are beneficial for the project itself:
nameoption to the Pipfile sources.This was required to make
pipfile lockrun through without error.pyyamlinstead of relying on the latest git branchI assume that installing from git was done to get around the recent issue of installing
pyyaml. With an updatedPipfile.lockthis workaround is no longer necessary.With an updated Python version, and the fixed
pyyamlversion we can use updated versions of everything.