Skip to content

Fix docker build & run#11

Merged
kevin1024 merged 1 commit intopsf:mainfrom
exhuma:fix-docker-build
Aug 14, 2023
Merged

Fix docker build & run#11
kevin1024 merged 1 commit intopsf:mainfrom
exhuma:fix-docker-build

Conversation

@exhuma
Copy link
Copy Markdown

@exhuma exhuma commented Aug 11, 2023

This fixes #10

To make everything work I needed to make three changes (explained below). I would say that all three are beneficial for the project itself:

  1. Add the name option to the Pipfile sources.
    This was required to make pipfile lock run through without error.
  2. Install an officially packaged version of pyyaml instead of relying on the latest git branch
    I assume that installing from git was done to get around the recent issue of installing pyyaml. With an updated Pipfile.lock this workaround is no longer necessary.
  3. Update the lock file
    With an updated Python version, and the fixed pyyaml version we can use updated versions of everything.

@exhuma
Copy link
Copy Markdown
Author

exhuma commented Aug 11, 2023

I'm not quite sure what happened to the checks. Seems like the macOS build has timed out? It simply says Error: The operation was canceled.

Any idea what I could do to fix that?

@kevin1024
Copy link
Copy Markdown

Some of the test runs have been a bit flaky. Not sure what the deal is. Thanks for your PRs though!

@kevin1024 kevin1024 merged commit 7012f1a into psf:main Aug 14, 2023
@exhuma exhuma deleted the fix-docker-build branch August 14, 2023 08:09
@exhuma exhuma mentioned this pull request Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeError: load() missing 1 required positional argument: 'Loader'

2 participants