Skip to content

Issue 2 customisable port#4

Merged
kevin1024 merged 4 commits intopsf:mainfrom
exhuma:issue-2-customisable-port
Aug 10, 2023
Merged

Issue 2 customisable port#4
kevin1024 merged 4 commits intopsf:mainfrom
exhuma:issue-2-customisable-port

Conversation

@exhuma
Copy link
Copy Markdown

@exhuma exhuma commented Jul 11, 2023

Proposal for an entry-point that allows changing the port that is used inside the container.

This is slightly in conflict with the EXPOSE line from the Dockerfile. But it works nonetheless. For most people, port 80 works so that should not play a big role. I don't know of a way to make the EXPOSE line variable for new container start-ups as the EXPOSE line is used during the build phase.

An alternative solution would be to simply start it up on a non-privileged port by default. But that is non backwards-compatible and will break existing deployments.

I had to make a slight adjustment to the pipenv call to make it work with newer versions of pipenv

@exhuma
Copy link
Copy Markdown
Author

exhuma commented Jul 11, 2023

I also exposed HTTPBIN_HOST but, when writing the docs I realised that this isn't really necessary. I kept it for consistency. But it might be confusing. I can remove that if you like.

@adigaboy
Copy link
Copy Markdown

Is there an update? looking forward for this change

@kevin1024 kevin1024 merged commit 74cd1d0 into psf:main Aug 10, 2023
@exhuma exhuma deleted the issue-2-customisable-port branch August 11, 2023 08:53
@exhuma exhuma mentioned this pull request Aug 18, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants