Skip to content

Make requests compliant with PEP 476#4932

Closed
ssbarnea wants to merge 1 commit intopsf:masterfrom
ssbarnea:fix/pep-0476
Closed

Make requests compliant with PEP 476#4932
ssbarnea wants to merge 1 commit intopsf:masterfrom
ssbarnea:fix/pep-0476

Conversation

@ssbarnea
Copy link
Contributor

@ssbarnea ssbarnea commented Jan 8, 2019

Enables loading of certificate bundles from SSL_CERT_FILE or
SSL_CERT_DIR as mentioned in https://legacy.python.org/dev/peps/pep-0476/

Current patch keeps backwards compatibility by preferring the more
specific options and using the new ones only as fallbacks.

Fixes: #2899

Enables loading of certificate bundles from SSL_CERT_FILE or
SSL_CERT_DIR as mentioned in https://legacy.python.org/dev/peps/pep-0476/

Current patch keeps backwards compatibility by preferring the more
specific options and using the new ones only as fallbacks.
@ofek
Copy link
Contributor

ofek commented Jan 12, 2019

@Lukasa Shouldn't this already have been on master via #2903?

Could it be due to this? 85a29f1

@nateprewitt
Copy link
Member

@ofek this was merged into the Proposed/3.0.0 branch which isn’t merged with master yet. I’m inclined to uphold the decision Lukasa made the last time this PR was proposed. We’ll treat this as a breaking change because it does have a high probability to break existing setups.

Thanks for the proposal @ssbarnea!

@Thaodan
Copy link

Thaodan commented Apr 25, 2019

Will work REQUESTS_CA_BUNDLE with capath until than too?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

requests: Support SSL_CERT_FILE environment variable

4 participants