nogui crash #370
Merged
nogui crash #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psieg
reviewed
Jul 5, 2020
|
|
||
| // Connections to signals which will be connected to ILedDevice | ||
| if (!m_noGui) | ||
| if (!m_noGui && m_settingsWindow) |
Owner
There was a problem hiding this comment.
Checking m_noGui is sufficient, or is there a case where !m_noGui && !m_settingsWindow?
Author
There was a problem hiding this comment.
now either combination should be enough, I just put both for extra..
there are places where neither are checked but I didn't trace every path, it seems to run as is though
what broke it is the addition of soundviz on linux (and mac)
Owner
There was a problem hiding this comment.
I thought so far the code was consistently checking m_noGui (except since the addition of soundviz-linux/mac), but fine, it doesn't really matter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#368